<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16245">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D16245#inline-88258">View Inline</a><span style="color: #4b4d51; font-weight: bold;">alarmdialog.cpp:147</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">KConfigGroup</span> <span style="color: #004012">generalConfig</span><span class="p">(</span><span class="n">config</span><span class="p">,</span> <span style="color: #766510">"General"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">QPoint</span></span><span class="bright"> </span><span class="n"><span class="bright">pos</span></span><span class="bright"> </span><span style="color: #aa2211">=</span> <span class="n">generalConfig</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"Position"</span><span class="p">,</span> <span class="n">Q<span class="bright">Point</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #601200"><span class="bright">0</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">mRect</span></span><span class="bright"> </span><span style="color: #aa2211">=</span> <span class="n">generalConfig</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"Position"</span><span class="p">,</span> <span class="n">Q<span class="bright">Rect</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">mRect</span><span class="p">.</span><span class="n">isNull</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is not compatible with the previous settings (because it was a <tt style="background: #ebebeb; font-size: 13px;">QPoint</tt>) - you should probably continue reading Position as <tt style="background: #ebebeb; font-size: 13px;">QPoint</tt> and add a new config entry instead called "Size" to read as <tt style="background: #ebebeb; font-size: 13px;">QSize</tt>. You can then construct a <tt style="background: #ebebeb; font-size: 13px;">QRect</tt> from <tt style="background: #ebebeb; font-size: 13px;">QPoint</tt> and <tt style="background: #ebebeb; font-size: 13px;">QSize</tt>. Remember to adjust saving the same way.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R210 KOrganizer</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D16245">https://phabricator.kde.org/D16245</a></div></div><br /><div><strong>To: </strong>dfries, mlaurent, dvratil<br /><strong>Cc: </strong>dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss<br /></div>