D13135: Introduce Storage::articlesForCache and more lazy-loading

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> feedstorage.h:45
> +
> +    SmallArticle(const QString &guid, int hash, int status, const QString &title, QDateTime pubDate)
> +        : guid(guid), hash(hash), status(status), title(title), pubDate(pubDate) {

const QDateTime &

> article.cpp:266
> +Article::Article(const Backend::SmallArticle &cachedArticle, Feed *feed, Backend::FeedStorage *archive)
> +    : d()
> +{

why not assign d directly here ?

> feedstoragedummyimpl.cpp:125
> +    result.reserve(d->entries.size());
> +    for (QString &guid: d->entries.keys()) {
> +        auto &entry = d->entries[guid];

const QString & ?

> feed.cpp:264
> +    QVector<Backend::SmallArticle> list = d->archive->articlesForCache();
> +    for (Backend::SmallArticle &article: list) {
> +        Article mya(article, this, d->archive);

const ... & ?

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D13135

To: pinaraf, cgiboudeaux
Cc: mlaurent, kde-pim, dvasin, rodsevich, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180528/a736104a/attachment.html>