D13104: Protocol: QJsonObject for tracer.

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Looks good, just a small request: use `QLatin1String` when comparing strings - generally `QLatin1String` is prefered if an overload that takes `QLatin1String` exists (like `QString::operator==(const QLatin1String &)` in this case) as it has the same performance cost as `QStringLiteral` but does not have the memory and code-size overhead of it.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D13104

To: knauss, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180526/15208177/attachment.html>