D10940: KSmtp: Option to use system proxy settings

[Jonathan Marten]

marten created this revision.
marten added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM.
marten requested review of this revision.

REVISION SUMMARY
  This is to provide an explicit option whether to use the system proxy setting for SMTP connections, as described in T7430 <https://phabricator.kde.org/T7430>.
  
  If the system proxy settings are set to use the environment variables http_proxy etc (for compatibility with non-KDE applications), then they are also used for SMTP connections. This is rarely required and will fail unless the proxy is transparent enough. See https://bugs.kde.org/show_bug.cgi?id=379539 and related bugs.
  
  This change adds a SMTP option to use the proxy for connection (the default is off). This is the core part of the change in KSmtp; the configuration option and the visible GUI part in KMailTransport will follow in another diff.

TEST PLAN
  Built KSmtp with this change, verified that by default the SMTP connection is not made via the proxy and that mail sending works as expected. Verified that, if the option is set, the SMTP connection is made via the proxy.

REPOSITORY
  R733 KSmtp

REVISION DETAIL
  https://phabricator.kde.org/D10940

AFFECTED FILES
  src/session.cpp
  src/session.h
  src/sessionthread.cpp
  src/sessionthread_p.h

To: marten, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180301/3f2130d2/attachment.html>