D11256: Fix KMail crash on exit, possibly accessing status bar during destruction

[Jonathan Marten]

marten created this revision.
marten added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM.
marten requested review of this revision.

REVISION SUMMARY
  The backtraces in bug https://bugs.kde.org/show_bug.cgi?id=387177 appear to show a crash as a result of accessing the main window's status bar during destruction, with running Akonadi jobs being killed and trying to show a status message.  By this time, the status bar has already been destroyed.
  
  This change disconnects the broadcast status message signal from the status bar before it is destroyed.

TEST PLAN
  Previously this crash happened regularly.  Since rebuilding kmail with this change, I have not experienced any such crash over a number of weeks when quitting the application, whether it is busy or not.

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D11256

AFFECTED FILES
  src/kmmainwin.cpp

To: marten, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180312/775974e0/attachment.html>