D11520: kldap: add support for TLS CA certificate handling

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  Looks good, just a minor nitpick regarding the strings - since they are localizable and thus can be shown to users, they should use proper terms

INLINE COMMENTS

> ldapconnection.cpp:303
> +            if(setOption(LDAP_OPT_X_TLS_CACERTFILE, d->mServer.tlsCACertFile().toUtf8().data()) != LDAP_OPT_SUCCESS) {
> +                d->mConnectionError = i18n("Could not set CA cert file.");
> +                return -1;

s/cert/certificate/

> ldapconnection.cpp:323
> +            if (setOption(LDAP_OPT_X_TLS_REQUIRE_CERT, &reqcert) != LDAP_OPT_SUCCESS) {
> +                d->mConnectionError = i18n("Could not set TLS require cert.");
> +                return -1;

s/cert/certificate/

> ldapconnection.cpp:332
> +            if (setOption(LDAP_OPT_X_TLS_NEWCTX, &isServer) != LDAP_OPT_SUCCESS) {
> +                d->mConnectionError = i18n("Could not init new TLS context");
> +                return -1;

s/init/initialize/

REPOSITORY
  R178 PIM: KLDAP

REVISION DETAIL
  https://phabricator.kde.org/D11520

To: junghans, mlaurent, dvratil
Cc: dvratil, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180320/4ea12dca/attachment.html>