<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11520">View Revision</a></tr></table><br /><div><div><p>Looks good, just a minor nitpick regarding the strings - since they are localizable and thus can be shown to users, they should use proper terms</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11520#inline-56839">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ldapconnection.cpp:303</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">setOption</span><span class="p">(</span><span class="n">LDAP_OPT_X_TLS_CACERTFILE</span><span class="p">,</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mServer</span><span class="p">.</span><span class="n">tlsCACertFile</span><span class="p">().</span><span class="n">toUtf8</span><span class="p">().</span><span class="n">data</span><span class="p">())</span> <span style="color: #aa2211">!=</span> <span class="n">LDAP_OPT_SUCCESS</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mConnectionError</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Could not set CA cert file."</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">return</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">s/cert/certificate/</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11520#inline-56838">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ldapconnection.cpp:323</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">setOption</span><span class="p">(</span><span class="n">LDAP_OPT_X_TLS_REQUIRE_CERT</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">reqcert</span><span class="p">)</span> <span style="color: #aa2211">!=</span> <span class="n">LDAP_OPT_SUCCESS</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mConnectionError</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Could not set TLS require cert."</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">return</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">s/cert/certificate/</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D11520#inline-56837">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ldapconnection.cpp:332</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">setOption</span><span class="p">(</span><span class="n">LDAP_OPT_X_TLS_NEWCTX</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">isServer</span><span class="p">)</span> <span style="color: #aa2211">!=</span> <span class="n">LDAP_OPT_SUCCESS</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mConnectionError</span> <span style="color: #aa2211">=</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Could not init new TLS context"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">return</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">s/init/initialize/</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R178 PIM: KLDAP</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11520">https://phabricator.kde.org/D11520</a></div></div><br /><div><strong>To: </strong>junghans, mlaurent, dvratil<br /><strong>Cc: </strong>dvratil, KDE PIM, dvasin, winterz, vkrause, mlaurent, knauss<br /></div>