D13756: Resourcebase docu: don't call changeCommitted from itemRemoved.

[David Faure]

dfaure created this revision.
dfaure added reviewers: dvratil, vkrause.
Restricted Application added a project: KDE PIM.
Restricted Application edited subscribers, added: kde-pim; removed: KDE PIM.
dfaure requested review of this revision.

REVISION SUMMARY
  This attempts to modify an item that was already removed from the DB,
  with a "No items found" warning as a result.
  
  Calling changeProcessed() is enough.
  That's what most resources do already (knut, maildir, mbox, icaldir,
  ical, vcard, kalarmdir, contacts, openxchange...).
  
  It gets harder for resources that have a generic slot though
  (e.g. GoogleResource::slotGenericJobFinished or
  TomboyNotesResource::onItemChangeCommitted).
  The davgroupware resource shows a possible solution for that:
  setting and testing modifyJob->property("isRemoval").toBool()
  
  MixedMaildirResource::itemRemovedResult also seems wrong and easily fixable.

TEST PLAN
  FatCRM's unittests no longer show that warning

REPOSITORY
  R165 Akonadi

BRANCH
  Applications/18.04

REVISION DETAIL
  https://phabricator.kde.org/D13756

AFFECTED FILES
  src/agentbase/resourcebase.h

To: dfaure, dvratil, vkrause
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180627/4a44ec54/attachment.html>