D14454: Port to setAutoSaveSettings so that saving happens before hiding.

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dfaure wrote in kmmainwin.cpp:100
> KConfig::sync is already called many many times, on the KMKernel config object, actually.
> 
> - In KMMainWidget, destruct() calls writeConfig(bool), which syncs.
> - MessageList::Pane::~Pane(), same thing
> - MessageList::Core::Manager::~Manager() calls saveConfiguration() which syncs
> 
> And more importantly (more reliably after KMMainWin), ~KMKernel calls KMKernel::slotSyncConfig() which does both KCoreConfigSkeleton::save() (which syncs) and a direct call to sync() (I'll remove that one...)

Ah ok indeed.
Thanks

REPOSITORY
  R206 KMail

BRANCH
  setautosavesettings

REVISION DETAIL
  https://phabricator.kde.org/D14454

To: dfaure, ngraham, elvisangelaccio, broulik, cfeck, mlaurent
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180731/b78f2c74/attachment.html>