D14454: Port to setAutoSaveSettings so that saving happens before hiding.

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> mlaurent wrote in kmmainwin.cpp:100
> now it's not necessary to call "KMKernel::self()->config()->sync();" ?

KConfig::sync is already called many many times, on the KMKernel config object, actually.

- In KMMainWidget, destruct() calls writeConfig(bool), which syncs.
- MessageList::Pane::~Pane(), same thing
- MessageList::Core::Manager::~Manager() calls saveConfiguration() which syncs

And more importantly (more reliably after KMMainWin), ~KMKernel calls KMKernel::slotSyncConfig() which does both KCoreConfigSkeleton::save() (which syncs) and a direct call to sync() (I'll remove that one...)

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D14454

To: dfaure, ngraham, elvisangelaccio, broulik, cfeck, mlaurent
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180731/1bd4142b/attachment.html>