D14163: Fix translation of country names
Volker Krause
noreply at phabricator.kde.org
Mon Jul 16 17:10:41 BST 2018
vkrause created this revision.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: kde-pim.
vkrause requested review of this revision.
REVISION SUMMARY
There is no catalog containing the country names right now, so calling
i18n() with country names has no effect. The iso-codes package provides
catalogs for this, so let's use that.
One could argue that this violates the dependency freeze, however it will
not change anything if the iso-codes package isn't present, you can still
build and get untranslated country names. It does however fix the issue
when iso-codes happens to be present, which is likely considering Plasma
depends on it already.
REPOSITORY
R174 PIM: KContacts
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14163
AFFECTED FILES
CMakeLists.txt
cmake/FindIsoCodes.cmake
src/address.cpp
To: vkrause
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180716/b3e67f2d/attachment.html>
More information about the kde-pim
mailing list