D14163: Fix translation of country names

[Pino Toscano]

pino added a comment.


  I noticed the recent changes in this file, so time to chime in.
  This approach only works if each English text (which happens to be the very first for each country, so that's why `ISOtoCountry()` "works") is **exactly** the same (including capitalization) as the country name specified in iso-codes. Also considering the history of this file, it is very much likely to miss changes done in the latest years...
  
  IMHO this code is simply beyond any repair -- users ought to use iso-codes for these tasks, and not just the catalogs but also the JSON/XML files for all the mappings.
  
  I have locally a prototype of library that uses only QtCore, QtXml, and KI18n for reading iso-codes data; I can publish it somewhere, and fix these issues once and for all.

REPOSITORY
  R174 PIM: KContacts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14163

To: vkrause, mlaurent
Cc: pino, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180716/40db9258/attachment.html>