D14127: Cache country <-> ISO code mapping in both directions

Volker Krause noreply at phabricator.kde.org
Sun Jul 15 13:06:49 BST 2018


vkrause added inline comments.

INLINE COMMENTS

> dvratil wrote in address.cpp:672
> Would it make sense to also insert the strings to the `isoToCountry` hash table to benefit QString's explicit sharing (and vice-verase in `ISOToCountry()`), or is it unlikely any code would benefit from this?

This could work in ISOtoCountry indeed, but here we would need to check if the language of the country name is the local one before inserting, which we have no way of detecting.

REPOSITORY
  R174 PIM: KContacts

REVISION DETAIL
  https://phabricator.kde.org/D14127

To: vkrause
Cc: dvratil, kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180715/9aab72f9/attachment.html>


More information about the kde-pim mailing list