KHolidays as Framework (redux)

[Dominik Haumann]

Am 20.01.2018 17:22 schrieb "Volker Krause" <vkrause at kde.org>:

Thanks, should be fixed now.


Certainly better, although code examples and the like still would make a
significant difference ;)

Cheers
Dominik




On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote:
> Hi,
>
> CC: only kdepim, kde-frameworks-devel
>
> I have some general comments about the API documentation. Looking at
> https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html
> the list mostly (only?) contains classes that are internal. Looking at
> https://github.com/KDE/kholidays/blob/master/src/holiday.h
> we can see documentation exists also for important classes, but the docs
> are not listed because the class documentation is missing.
>
> This is not a showstopper, but without accessible API, the visibility of
> this framework is much reduced. It would be nice, if the API documentation
> is complete, so here is still some room for improvement ;)
>
> Best regards
> Dominik
>
>
>
> Am 20.01.2018 11:39 schrieb "Volker Krause" <vkrause at kde.org>:
>
> On Sunday, 14 January 2018 12:55:30 CET David Faure wrote:
> > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote:
> > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > > Hi,
> > > > > >
> > > > > > It's xmas holidays, so it must be time to poke a stick at
>
> KHolidays
>
> > > > > > again
> > > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > > outstanding
> > > > > > porting issues with KHolidays and it is ready for review to be
> > > > > > included
> > > > > > as
> > > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > > step?
> > > > >
> > > > > Please make sure it passes all of the items in this checklist
> > > > > https://community.kde.org/Frameworks/CreationGuidelines
> > > >
> > > > AFAICS this is followed, apart from using the KF5 version number and
> > > > actually being marked as a framework, which I guess is pending
>
> framework
>
> > > > approval.
> > >
> > > This got lost somehow, any objection to executing the move to
frameworks
> > > for 5.43, say end of this week?
> >
> > Go ahead.
>
> The necessary metainfo and CMake changes are pushed, the sysadmin ticket
for
> the repo metadata change is T7791.
>
> Summary: KHolidays will not be part of the 18.x KDE Application releases
> anymore, but instead become part of the KDE Frameworks releases with
version
> 5.43. There are no ABI or name changes, just the .so version increases
from
> 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully
be
> hardly noticeable.
> Side benefit: plasma-workspace no longer depends on a library from KDE
> Application releases.
>
> Regards,
> Volker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180120/47b54cdc/attachment.html>