D10011: make cmake/FindLibIcal.cmake ready for cross compilation.

Christophe Giboudeaux noreply at phabricator.kde.org
Tue Jan 23 10:43:55 GMT 2018


cgiboudeaux added a comment.


  In https://phabricator.kde.org/D10011#194662, @knauss wrote:
  
  > @cgiboudeaux: did you checked on Windows? Is the whole WIN32 block is still needed, or can it removed completly?
  
  
  https://community.kde.org/Policies/CMake_Coding_Style#.28Not.29_Using_pkg-config
  
  > putting something like if(NOT WIN32) around the pkg-config stuff is not necessary (and should be removed if it is somewhere). If pkg-config is not found, e.g. on Windows, the macros simply do nothing.

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D10011

To: knauss, #kde_pim, winterz
Cc: cgiboudeaux, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180123/672cfe33/attachment.html>


More information about the kde-pim mailing list