D10317: POP3 resource: Option to use system proxy settings (Core part)

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> pop3.cpp:619
> +
> +    if (!hasMetaData(QStringLiteral("useProxy")) || metaData(QStringLiteral("useProxy")) != QLatin1String("on"))
> +    {

coding style if(...) {

> pop3.cpp:624
> +        KTcpSocket *sock = qobject_cast<KTcpSocket *>(socket());
> +        if (sock != nullptr)
> +        {

if (sock) {

> pop3.cpp:630
> +        }
> +        else qCWarning(POP3_LOG) << "no socket, cannot set no proxy";
> +    }

} else {
...
}

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D10317

To: marten, #kde_pim
Cc: mlaurent, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180205/55599abf/attachment.html>