D10317: POP3 resource: Option to use system proxy settings (Core part)

[Jonathan Marten]

marten created this revision.
marten added a reviewer: KDE PIM.
Restricted Application added a project: KDE PIM.
marten requested review of this revision.

REVISION SUMMARY
  This is to provide an explicit option to not use the system proxy setting for POP3 connections, as described in https://phabricator.kde.org/T7430.
  
  If the system proxy settings are set to use the environment variables http_proxy etc (for compatibility with non-KDE applications), then they are also used for POP3 connections.  This is rarely required and will fail unless the proxy is transparent enough.  See https://bugs.kde.org/show_bug.cgi?id=373870 and related bugs.
  
  This change adds a POP3 account option to use the proxy for connection (the default is off).  This is the core part of the change;  the visible GUI part will follow in another diff.

TEST PLAN
  Built pimruntime with this change, verified that by default the POP3 connection is not made via the proxy and that mail fetching works as expected.  Verified that, if the option is set, the POP3 connection is made via the proxy.

REPOSITORY
  R44 KDE PIM Runtime

REVISION DETAIL
  https://phabricator.kde.org/D10317

AFFECTED FILES
  kioslave/pop3/CMakeLists.txt
  kioslave/pop3/pop3.cpp
  resources/pop3/jobs.cpp
  resources/pop3/settings.kcfg

To: marten, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180205/a41f00fb/attachment.html>