D14986: ItemSync can be canceled but not defered. Add assert and debug output.

[David Faure]

dfaure updated this revision to Diff 40353.
dfaure added a comment.


  Use qCDebug

REPOSITORY
  R165 Akonadi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14986?vs=40189&id=40353

BRANCH
  2018_08_defer_assert

REVISION DETAIL
  https://phabricator.kde.org/D14986

AFFECTED FILES
  CMakeLists.txt
  KF5AkonadiMacros.cmake
  akonadi.categories
  akonadiwidgetstests_export.h.in
  autotests/agentbase2/CMakeLists.txt
  autotests/akonadicontrol/CMakeLists.txt
  autotests/libs/CMakeLists.txt
  autotests/libs/actionstatemanagertest.cpp
  autotests/libs/cachepolicytest.cpp
  autotests/libs/cachepolicytest.h
  autotests/libs/collectionattributetest.cpp
  autotests/libs/collectioncreatetest.cpp
  autotests/libs/collectionsynctest.cpp
  autotests/libs/conflictresolvedialogtest.cpp
  autotests/libs/conflictresolvedialogtest.h
  autotests/libs/fakeakonadiservercommand.h
  autotests/libs/fakeentitycache.h
  autotests/libs/inspectablechangerecorder.cpp
  autotests/libs/itemmovetest.cpp
  autotests/libs/linktest.cpp
  autotests/libs/monitornotificationtest.cpp
  autotests/libs/newmailnotifierattributetest.cpp
  autotests/libs/newmailnotifierattributetest.h
  autotests/libs/pop3resourceattributetest.cpp
  autotests/libs/pop3resourceattributetest.h
  autotests/libs/protocolhelpertest.cpp
  autotests/libs/tagselectwidgettest.cpp
  autotests/libs/tagselectwidgettest.h
  autotests/libs/tagtest.cpp
  autotests/libs/testresource/CMakeLists.txt
  autotests/libs/testresource/knutresource.h
  autotests/libs/testrunner/main.cpp
  autotests/libs/testrunner/setup.cpp
  autotests/libs/testrunner/shellscript.cpp
  autotests/libs/testrunner/testrunner.cpp
  autotests/private/akstandarddirstest.cpp
  autotests/private/notificationmessagetest.cpp
  autotests/private/protocoltest.cpp
  autotests/server/CMakeLists.txt
  autotests/server/akappendhandlertest.cpp
  autotests/server/collectionreferencetest.cpp
  autotests/server/collectionstatisticstest.cpp
  autotests/server/createhandlertest.cpp
  autotests/server/dbconfigtest.cpp
  autotests/server/dbinitializer.cpp
  autotests/server/dbinitializer.h
  autotests/server/dbpopulator.h
  autotests/server/dbpopulator.xsl
  autotests/server/fakeakonadiserver.cpp
  autotests/server/fakeakonadiserver.h
  autotests/server/fakeclient.cpp
  autotests/server/fakeclient.h
  autotests/server/fakeconnection.cpp
  autotests/server/fakeconnection.h
  autotests/server/fakedatastore.cpp
  autotests/server/fakedatastore.h
  autotests/server/fakeitemretrievalmanager.cpp
  autotests/server/fakesearchmanager.h
  autotests/server/fetchhandlertest.cpp
  autotests/server/handlertest.cpp
  autotests/server/inspectablenotificationcollector.cpp
  autotests/server/inspectablenotificationcollector.h
  autotests/server/linkhandlertest.cpp
  autotests/server/modifyhandlertest.cpp
  autotests/server/movehandlertest.cpp
  autotests/server/notificationmanagertest.cpp
  autotests/server/partstreamertest.cpp
  autotests/server/relationhandlertest.cpp
  autotests/server/taghandlertest.cpp
  cmake/modules/AkonadiMacros.cmake
  cmake/modules/FindXsltproc.cmake
  metainfo.yaml
  src/agentbase/agentbase.cpp
  src/agentbase/agentbase.h
  src/agentbase/agentbase_p.h
  src/agentbase/agentfactory.h
  src/agentbase/preprocessorbase.h
  src/agentbase/resourcebase.cpp
  src/agentbase/resourcebase.h
  src/agentbase/resourcescheduler_p.h
  src/agentbase/resourcesettings.cpp
  src/agentbase/resourcesettings.h
  src/agentbase/transportresourcebase.cpp
  src/agentserver/CMakeLists.txt
  src/agentserver/agentpluginloader.cpp
  src/agentserver/agentpluginloader.h
  src/agentserver/agentserver.cpp
  src/akonadicontrol/agentinstance.cpp
  src/akonadicontrol/agentinstance.h
  src/akonadicontrol/agentmanager.cpp
  src/akonadicontrol/agentprocessinstance.cpp
  src/akonadicontrol/agentprocessinstance.h
  src/akonadicontrol/agentthreadinstance.h
  src/akonadicontrol/agenttype.cpp
  src/akonadicontrol/agenttype.h
  src/akonadicontrol/processcontrol.cpp
  src/akonadicontrol/processcontrol.h
  src/akonadictl/CMakeLists.txt
  src/akonadictl/akonadistarter.cpp
  src/akonadictl/akonadistarter.h
  src/akonadictl/main.cpp
  src/asapcat/main.cpp
  src/asapcat/session.cpp
  src/asapcat/session.h
  src/core/CMakeLists.txt
  src/core/agentinstance.cpp
  src/core/agentinstance.h
  src/core/agentmanager.cpp
  src/core/agentmanager.h
  src/core/agentmanager_p.h
  src/core/agenttype.h
  src/core/attributefactory.cpp
  src/core/braveheart.cpp
  src/core/cachepolicy.cpp
  src/core/cachepolicy.h
  src/core/changenotification.h
  src/core/changenotificationdependenciesfactory.cpp
  src/core/changenotificationdependenciesfactory_p.h
  src/core/changerecorder.h
  src/core/changerecorder_p.cpp
  src/core/collection.h
  src/core/collectioncolorattribute.cpp
  src/core/collectioncolorattribute.h
  src/core/collectionfetchscope.cpp
  src/core/collectionfetchscope.h
  src/core/collectionidentificationattribute.cpp
  src/core/collectionidentificationattribute.h
  src/core/collectionpathresolver.cpp
  src/core/collectionpathresolver.h
  src/core/collectionquotaattribute.h
  src/core/collectionrightsattribute_p.h
  src/core/collectionstatistics.cpp
  src/core/collectionstatistics.h
  src/core/collectionsync.cpp
  src/core/collectionsync_p.h
  src/core/collectionutils.h
  src/core/commandbuffer_p.h
  src/core/conflicthandler.cpp
  src/core/connection.cpp
  src/core/connection_p.h
  src/core/control.cpp
  src/core/control.h
  src/core/entityannotationsattribute.cpp
  src/core/entitycache_p.h
  src/core/entitydeletedattribute.h
  src/core/entitydisplayattribute.cpp
  src/core/entitydisplayattribute.h
  src/core/entityhiddenattribute.h
  src/core/exceptionbase.h
  src/core/favoritecollectionattribute.cpp
  src/core/favoritecollectionattribute.h
  src/core/firstrun.cpp
  src/core/indexpolicyattribute.cpp
  src/core/indexpolicyattribute.h
  src/core/item.cpp
  src/core/item.h
  src/core/item_p.h
  src/core/itemfetchscope.h
  src/core/itempayloadinternals_p.h
  src/core/itemserializer.cpp
  src/core/itemsync.cpp
  src/core/itemsync.h
  src/core/jobs/agentinstancecreatejob.cpp
  src/core/jobs/agentinstancecreatejob.h
  src/core/jobs/collectionattributessynchronizationjob.h
  src/core/jobs/collectioncopyjob.h
  src/core/jobs/collectioncreatejob.h
  src/core/jobs/collectiondeletejob.h
  src/core/jobs/collectionfetchjob.cpp
  src/core/jobs/collectionfetchjob.h
  src/core/jobs/collectionmodifyjob.h
  src/core/jobs/collectionstatisticsjob.h
  src/core/jobs/invalidatecachejob.cpp
  src/core/jobs/invalidatecachejob_p.h
  src/core/jobs/itemcopyjob.h
  src/core/jobs/itemcreatejob.cpp
  src/core/jobs/itemcreatejob.h
  src/core/jobs/itemdeletejob.cpp
  src/core/jobs/itemdeletejob.h
  src/core/jobs/itemfetchjob.cpp
  src/core/jobs/itemfetchjob.h
  src/core/jobs/itemmodifyjob.cpp
  src/core/jobs/itemmodifyjob.h
  src/core/jobs/itemmovejob.h
  src/core/jobs/itemsearchjob.cpp
  src/core/jobs/itemsearchjob.h
  src/core/jobs/job.cpp
  src/core/jobs/job.h
  src/core/jobs/job_p.h
  src/core/jobs/linkjob.h
  src/core/jobs/recursiveitemfetchjob.cpp
  src/core/jobs/recursiveitemfetchjob.h
  src/core/jobs/relationcreatejob.h
  src/core/jobs/relationdeletejob.h
  src/core/jobs/relationfetchjob.h
  src/core/jobs/resourcesynchronizationjob.cpp
  src/core/jobs/resourcesynchronizationjob.h
  src/core/jobs/searchcreatejob.cpp
  src/core/jobs/searchcreatejob.h
  src/core/jobs/searchresultjob.cpp
  src/core/jobs/searchresultjob_p.h
  src/core/jobs/specialcollectionsdiscoveryjob.h
  src/core/jobs/specialcollectionshelperjobs.cpp
  src/core/jobs/specialcollectionshelperjobs_p.h
  src/core/jobs/specialcollectionsrequestjob.cpp
  src/core/jobs/specialcollectionsrequestjob.h
  src/core/jobs/subscriptionjob_p.h
  src/core/jobs/tagcreatejob.cpp
  src/core/jobs/tagcreatejob.h
  src/core/jobs/tagdeletejob.h
  src/core/jobs/tagfetchjob.cpp
  src/core/jobs/tagfetchjob.h
  src/core/jobs/tagmodifyjob.cpp
  src/core/jobs/tagmodifyjob.h
  src/core/jobs/transactionjobs.h
  src/core/jobs/transactionsequence.cpp
  src/core/jobs/transactionsequence.h
  src/core/jobs/trashjob.h
  src/core/jobs/trashrestorejob.cpp
  src/core/jobs/trashrestorejob.h
  src/core/jobs/unlinkjob.h
  src/core/mimetypechecker.h
  src/core/models/agentfilterproxymodel.h
  src/core/models/agentinstancemodel.cpp
  src/core/models/agentinstancemodel.h
  src/core/models/agenttypemodel.cpp
  src/core/models/agenttypemodel.h
  src/core/models/collectionfilterproxymodel.cpp
  src/core/models/collectionfilterproxymodel.h
  src/core/models/collectionmodel.cpp
  src/core/models/collectionmodel.h
  src/core/models/collectionmodel_p.cpp
  src/core/models/collectionmodel_p.h
  src/core/models/entitymimetypefiltermodel.h
  src/core/models/entityorderproxymodel.cpp
  src/core/models/entityorderproxymodel.h
  src/core/models/entityrightsfiltermodel.h
  src/core/models/entitytreemodel.cpp
  src/core/models/entitytreemodel.h
  src/core/models/entitytreemodel_p.cpp
  src/core/models/favoritecollectionsmodel.cpp
  src/core/models/favoritecollectionsmodel.h
  src/core/models/itemmodel.h
  src/core/models/quotacolorproxymodel.cpp
  src/core/models/quotacolorproxymodel.h
  src/core/models/recursivecollectionfilterproxymodel.cpp
  src/core/models/recursivecollectionfilterproxymodel.h
  src/core/models/statisticsproxymodel.cpp
  src/core/models/statisticsproxymodel.h
  src/core/models/subscriptionmodel_p.h
  (253 more files...)

To: dfaure, dvratil, vkrause
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180824/fe25b511/attachment.html>