D14563: Add CLDR-based country to ISO code mapping

Volker Krause noreply at phabricator.kde.org
Thu Aug 2 20:52:04 BST 2018


vkrause added inline comments.

INLINE COMMENTS

> svuorela wrote in translatedcountrylist.h:29
> iirc, I also did some basic unit testing of these functions. Maybe we should integrate them as well ?

Yep, that's where some of the extra tests came from. I didn't include the tests of the intermediate parsing stage, as they would not add any extra safety, so the extra work needed to enable that seems not worth the effort.

REPOSITORY
  R174 PIM: KContacts

REVISION DETAIL
  https://phabricator.kde.org/D14563

To: vkrause
Cc: svuorela, winterz, kde-pim, dvasin, rodsevich, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180802/1a51aa19/attachment.html>


More information about the kde-pim mailing list