D12480: Several performance optimisations for Akregator

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> feedstoragedummyimpl.cpp:215
> +{
> +    if (contains(guid)) {
> +        auto &entry = d->entries[guid];

Since we are talking performance here, I'd suggest using

  const auto it = d->entries.constFind(guid);
  if (it != d->entries.cend()) {
      ....
  }

This way you avoid looking up the the entry in the hashtable twice (once in `contains()` and once in `operator[]`).

> feed.cpp:403-405
> -    if (enabled) {
> -        createMarkAsReadJob()->start();
> -    }

This change does not seem related, could you explain it a bit more?

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D12480

To: pinaraf
Cc: dvratil, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180424/e51ab312/attachment.html>