D12480: Several performance optimisations for Akregator
Pierre Ducroquet
noreply at phabricator.kde.org
Mon Apr 23 22:40:16 BST 2018
pinaraf created this revision.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: KDE PIM.
pinaraf requested review of this revision.
REVISION SUMMARY
1. Fetch title, pubdate, hash and status in a single storage call
Even with MK4, the performance gain is sensible.
For medium sized archives (~25k articles), it's feeling faster.
For huge archives (>100k articles), it is human measurably faster.
2. Reuse the FeedStorage instead of fetching it for each article
For huge archives, this helps performance a bit
3. Drop useless call to isNull in model
All calls are safe even when the article is null.
And their results will be similar to QVariant().
This call is thus useless, and one of the biggest 'perf' offender
REPOSITORY
R201 Akregator
BRANCH
performances
REVISION DETAIL
https://phabricator.kde.org/D12480
AFFECTED FILES
interfaces/article.h
interfaces/feedstorage.h
plugins/mk4storage/feedstoragemk4impl.cpp
plugins/mk4storage/feedstoragemk4impl.h
src/article.cpp
src/articlemodel.cpp
src/dummystorage/feedstoragedummyimpl.cpp
src/dummystorage/feedstoragedummyimpl.h
src/feed/feed.cpp
To: pinaraf
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20180423/541eca10/attachment.html>
More information about the kde-pim
mailing list