D8353: Resolve body part URL handlers based on part mimetype
Volker Krause
noreply at phabricator.kde.org
Wed Oct 18 16:27:13 BST 2017
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.
This makes sense and looks good to me. I still fail to understand why this worked before though, I just moved this code to a different location :)
Mapping this to the render plugin that was used is tricky, as we do not persist that information, nor will it always be a single plugin responsible for drawing one part, so I think the mimetype approach works well for this.
Looking forward, I think the URL handling has a deeper problem by using BodyPart rather than MessagePart anyway. While changing that we might want to re-think the URL schema used by makeLink() to disambiguate on that level already.
REPOSITORY
R94 PIM: Message Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8353
To: dvratil, vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171018/16caa317/attachment.html>
More information about the kde-pim
mailing list