D8353: Resolve body part URL handlers based on part mimetype

Sandro Knauß noreply at phabricator.kde.org
Wed Oct 18 16:48:05 BST 2017


knauss added a comment.


  In https://phabricator.kde.org/D8353#156898, @vkrause wrote:
  
  > This makes sense and looks good to me. I still fail to understand why this worked before though, I just moved this code to a different location :)
  >  Mapping this to the render plugin that was used is tricky, as we do not persist that information, nor will it always be a single plugin responsible for drawing one part, so I think the mimetype approach works well for this.
  
  
  Wait we know excatly, that a plugin was used for one email, when DefaultRendererPrivate::renderWithFactory retruns true. So adding afterwarts the loading for URLHandler here would result in the correct URLHandlers loaded. This was done before too.
  
  > While changing that we might want to re-think the URL schema used by makeLink() to disambiguate on that level already.
  
  +1

REPOSITORY
  R94 PIM: Message Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8353

To: dvratil, vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171018/bd5d73ef/attachment.html>


More information about the kde-pim mailing list