D8125: Integrate the attachment block markers into the attachment templates

[Sandro Knauß]

knauss accepted this revision.
knauss added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> vkrause wrote in asiconpart.html:4
> Well, this change moves the burden of adding the attachment blocks into the Grantlee templates and out of the individual plugins. This is what makes the current code of https://phabricator.kde.org/D8122 work without requiring any handling of isAttachment(). I think that is a step in the right direction.
> 
> It might indeed be something we can add centrally in DefaultRenderer, and possibly even make non-conditional (having this for non-attachments doesn't really hurt after all), but that's a further improvement IMHO.

> Well, this change moves the burden of adding the attachment blocks into the Grantlee templates and out of the individual plugins. This is what makes the current code of https://phabricator.kde.org/D8122 work without requiring any handling of isAttachment(). I think that is a step in the right direction.

yepp you are right +1

REPOSITORY
  R94 PIM: Message Library

BRANCH
  top

REVISION DETAIL
  https://phabricator.kde.org/D8125

To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171003/e8330f64/attachment.html>