D8125: Integrate the attachment block markers into the attachment templates

[Sandro Knauß]

knauss added a comment.


  Also to do this with the root block would add a lot of global logic into the grantlee themes. Maybe we find a better solution for this.

INLINE COMMENTS

> asiconpart.html:4
> +<div id="attachmentDiv{{block.attachmentIndex}}">
> +{% endif %}
>  <hr/>

not really happy with this change, becuase it makes it harder to read. and mire error prune to forget a clossing "</div>".
Also maybe we want this logic to be done globally, to deside, ok this is an attachment, so we add this block to the part. IMO it doesn't makes sense to add this to every plugin. And to make the links usefull for kmail to jump to attachments we need these links.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D8125

To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171003/8f7cced5/attachment.html>