D8165: Added Auto-Expand Folder On Unread option

[Daniel Vrátil]

dvratil requested changes to this revision.
dvratil added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> selectioncontroller.cpp:277
> +
> +    for (int row=startRow; row <= endRow; ++row) {
> +        QModelIndex idx = m_subscriptionModel->index(row, 0, parent);

Spaces around `=`

> subscriptionlistview.cpp:430
> +
> +        for (int row=0; row < rows; ++row) {
> +            QModelIndex current = m->index(row, 0, parent);

Spaces around `=`

> subscriptionlistview.cpp:438
> +            if (m->data(current, SubscriptionListModel::HasUnreadRole).toBool()) {
> +                continue;
> +            }

Shouldn't this call `setExpanded(current, true)`? The condition implies that the `current` index has unread (sub)feeds and thus should be expanded, no?

REPOSITORY
  R201 Akregator

REVISION DETAIL
  https://phabricator.kde.org/D8165

To: sagara, dvratil
Cc: dvratil, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171007/754c2367/attachment.html>