<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8165" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8165#inline-34268" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">selectioncontroller.cpp:277</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">row</span><span style="color: #aa2211">=</span><span class="n">startRow</span><span class="p">;</span> <span class="n">row</span> <span style="color: #aa2211"><=</span> <span class="n">endRow</span><span class="p">;</span> <span style="color: #aa2211">++</span><span class="n">row</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QModelIndex</span> <span class="n">idx</span> <span style="color: #aa2211">=</span> <span class="n">m_subscriptionModel</span><span style="color: #aa2211">-></span><span class="n">index</span><span class="p">(</span><span class="n">row</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">parent</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Spaces around <tt style="background: #ebebeb; font-size: 13px;">=</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8165#inline-34269" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">subscriptionlistview.cpp:430</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">for</span> <span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">row</span><span style="color: #aa2211">=</span><span style="color: #601200">0</span><span class="p">;</span> <span class="n">row</span> <span style="color: #aa2211"><</span> <span class="n">rows</span><span class="p">;</span> <span style="color: #aa2211">++</span><span class="n">row</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">QModelIndex</span> <span class="n">current</span> <span style="color: #aa2211">=</span> <span class="n">m</span><span style="color: #aa2211">-></span><span class="n">index</span><span class="p">(</span><span class="n">row</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span class="n">parent</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Spaces around <tt style="background: #ebebeb; font-size: 13px;">=</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8165#inline-34270" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">subscriptionlistview.cpp:438</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m</span><span style="color: #aa2211">-></span><span class="n">data</span><span class="p">(</span><span class="n">current</span><span class="p">,</span> <span class="n">SubscriptionListModel</span><span style="color: #aa2211">::</span><span class="n">HasUnreadRole</span><span class="p">).</span><span class="n">toBool</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">continue</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Shouldn't this call <tt style="background: #ebebeb; font-size: 13px;">setExpanded(current, true)</tt>? The condition implies that the <tt style="background: #ebebeb; font-size: 13px;">current</tt> index has unread (sub)feeds and thus should be expanded, no?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R201 Akregator</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8165" rel="noreferrer">https://phabricator.kde.org/D8165</a></div></div><br /><div><strong>To: </strong>sagara, dvratil<br /><strong>Cc: </strong>dvratil, KDE PIM, dvasin, winterz, vkrause, mlaurent, knauss<br /></div>