D8179: Extend MessagePart API as needed for porting the vcard plugin

Volker Krause noreply at phabricator.kde.org
Mon Oct 9 20:24:41 BST 2017


vkrause added inline comments.

INLINE COMMENTS

> knauss wrote in messagepart.cpp:105
> add the classname of the messagepart to the mementoname/or replace it with this, with that we can also replace encryption and signature with this function.

I can't do that (yet), it would break code using the BodyPart based memento API, which uses the same key. Killing (or at least massively stripping down) BodyPart is on the TODO list though, which would enable this eventually.

> knauss wrote in messagepart.cpp:150
> no code duplication just run the old method till you delete the old method

And how would I get to the old code from here? BodyPart is a short-lived object only existing during processing.

REPOSITORY
  R94 PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D8179

To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171009/d020da8f/attachment.html>


More information about the kde-pim mailing list