D8124: Expose MessagePart directly to the attachment Grantlee templates

Volker Krause noreply at phabricator.kde.org
Tue Oct 3 12:40:20 BST 2017


vkrause created this revision.
vkrause added a reviewer: knauss.
Restricted Application added a project: KDE PIM.
Restricted Application added a subscriber: KDE PIM.

REVISION SUMMARY
  This reduces code duplication and makes this easier to re-use for plugins.
  Additionally, it fixes two issues with attachment rendering:
  
  - for many attachments we weren't showing links, making it unnecessarily hard to save or open them
  - we were double-escaping attachment labels and descriptions

REPOSITORY
  R94 PIM: Message Library

BRANCH
  top

REVISION DETAIL
  https://phabricator.kde.org/D8124

AFFECTED FILES
  messageviewer/src/messagepartthemes/default/plugins/attachmentmessagepartrenderer.cpp
  messageviewer/src/messagepartthemes/default/plugins/textmessagepartrenderer.cpp
  mimetreeparser/autotests/data/attachment-name-escaping.mbox
  mimetreeparser/autotests/data/attachment-name-escaping.mbox.html
  mimetreeparser/autotests/data/attachment-name-escaping.mbox.tree
  mimetreeparser/autotests/data/details/openpgp-encrypted-partially-signed-attachments.mbox.html
  mimetreeparser/autotests/data/details/openpgp-signed-encrypted-two-attachments.mbox.html
  mimetreeparser/autotests/data/details/openpgp-signed-two-attachments.mbox.html
  mimetreeparser/autotests/data/headeronly/attachment-name-escaping.mbox.html
  mimetreeparser/autotests/data/hidden/attachment-name-escaping.mbox.html
  mimetreeparser/autotests/data/iconic/attachment-name-escaping.mbox.html
  mimetreeparser/autotests/data/inlined/encapsulated-with-attachment.mbox.html
  mimetreeparser/autotests/data/inlined/openpgp-encrypted-attachment-and-non-encrypted-attachment.mbox.html
  mimetreeparser/autotests/data/inlined/openpgp-encrypted-attachment.mbox.html
  mimetreeparser/autotests/data/inlined/openpgp-signed-mailinglist+additional-children.mbox.html
  mimetreeparser/autotests/data/openpgp-encrypted-partially-signed-attachments.mbox.html
  mimetreeparser/autotests/data/openpgp-encrypted-two-attachments.mbox.html
  mimetreeparser/autotests/data/openpgp-signed-encrypted-two-attachments.mbox.html
  mimetreeparser/autotests/data/openpgp-signed-two-attachments.mbox.html
  mimetreeparser/src/bodyformatter/textplain.cpp
  mimetreeparser/src/viewer/messagepart.cpp
  mimetreeparser/src/viewer/messagepart.h

To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171003/c5c320ea/attachment.html>


More information about the kde-pim mailing list