<table><tr><td style="">vkrause created this revision.<br />vkrause added a reviewer: knauss.<br />Restricted Application added a project: KDE PIM.<br />Restricted Application added a subscriber: KDE PIM.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8124" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This reduces code duplication and makes this easier to re-use for plugins.<br />
Additionally, it fixes two issues with attachment rendering:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">for many attachments we weren't showing links, making it unnecessarily hard to save or open them</li>
<li class="remarkup-list-item">we were double-escaping attachment labels and descriptions</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R94 PIM: Message Library</div></div></div><br /><div><strong>BRANCH</strong><div><div>top</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8124" rel="noreferrer">https://phabricator.kde.org/D8124</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>messageviewer/src/messagepartthemes/default/plugins/attachmentmessagepartrenderer.cpp<br />
messageviewer/src/messagepartthemes/default/plugins/textmessagepartrenderer.cpp<br />
mimetreeparser/autotests/data/attachment-name-escaping.mbox<br />
mimetreeparser/autotests/data/attachment-name-escaping.mbox.html<br />
mimetreeparser/autotests/data/attachment-name-escaping.mbox.tree<br />
mimetreeparser/autotests/data/details/openpgp-encrypted-partially-signed-attachments.mbox.html<br />
mimetreeparser/autotests/data/details/openpgp-signed-encrypted-two-attachments.mbox.html<br />
mimetreeparser/autotests/data/details/openpgp-signed-two-attachments.mbox.html<br />
mimetreeparser/autotests/data/headeronly/attachment-name-escaping.mbox.html<br />
mimetreeparser/autotests/data/hidden/attachment-name-escaping.mbox.html<br />
mimetreeparser/autotests/data/iconic/attachment-name-escaping.mbox.html<br />
mimetreeparser/autotests/data/inlined/encapsulated-with-attachment.mbox.html<br />
mimetreeparser/autotests/data/inlined/openpgp-encrypted-attachment-and-non-encrypted-attachment.mbox.html<br />
mimetreeparser/autotests/data/inlined/openpgp-encrypted-attachment.mbox.html<br />
mimetreeparser/autotests/data/inlined/openpgp-signed-mailinglist+additional-children.mbox.html<br />
mimetreeparser/autotests/data/openpgp-encrypted-partially-signed-attachments.mbox.html<br />
mimetreeparser/autotests/data/openpgp-encrypted-two-attachments.mbox.html<br />
mimetreeparser/autotests/data/openpgp-signed-encrypted-two-attachments.mbox.html<br />
mimetreeparser/autotests/data/openpgp-signed-two-attachments.mbox.html<br />
mimetreeparser/src/bodyformatter/textplain.cpp<br />
mimetreeparser/src/viewer/messagepart.cpp<br />
mimetreeparser/src/viewer/messagepart.h</div></div></div><br /><div><strong>To: </strong>vkrause, knauss<br /><strong>Cc: </strong>KDE PIM, dvasin, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>