D8195: Improve render plugin selection

Sandro Knauß noreply at phabricator.kde.org
Tue Oct 10 09:05:43 BST 2017


knauss accepted this revision.
knauss added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> vkrause wrote in messagepartrendererfactory.cpp:157
> That would require all plugins (and all internal renderers) to actually specify a mimetype. That is not currently the case, so we treat that as a renderer that can handle any mimetype, and thus also with the lowest priority, as its most generic. For those having a 1:1 mapping to custom part types that is perfectly fine, no need for a mimetype there anyway.

ah okay this loop kicks out all elements that result with true. I first read it like, only elementents that result true will be keeped in the list.

REPOSITORY
  R94 PIM: Message Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8195

To: vkrause, knauss
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171010/ebde697e/attachment.html>


More information about the kde-pim mailing list