D8968: Prevent index out of range in case of empty or malformed filename

[Sandro Knauß]

knauss added a comment.


  well from the comment above in the code your code makes sence and return an empty string is not intended.

INLINE COMMENTS

> externalpartstorage.cpp:98
>                           + (revPos > 1 ? filename[revPos - 2] : QLatin1Char('0'))
> -                         + filename[revPos - 1]
> +                         + (revPos > 1 ? filename[revPos - 1] : QLatin1Char('0'))
>                           + QDir::separator()

> 0 is enough here.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D8968

To: ahartmetz, #kde_pim, dvratil
Cc: knauss, #kde_pim, dvasin, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20171123/b7eca69f/attachment.html>