<table><tr><td style="">knauss added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8968" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>well from the comment above in the code your code makes sence and return an empty string is not intended.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D8968#inline-40104" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">externalpartstorage.cpp:98</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                         <span style="color: #aa2211">+</span> <span class="p">(</span><span class="n">revPos</span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span> <span style="color: #aa2211">?</span> <span class="n">filename</span><span class="p">[</span><span class="n">revPos</span> <span style="color: #aa2211">-</span> <span style="color: #601200">2</span><span class="p">]</span> <span style="color: #aa2211">:</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">'0'</span><span class="p">))</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                         <span style="color: #aa2211">+</span> <span class="n">filename</span><span class="p">[</span><span class="n">revPos</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">]</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                         <span style="color: #aa2211">+</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">revPos</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">></span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span class="n">filename</span><span class="p">[</span><span class="n">revPos</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span><span class="p">]<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span class="n"><span class="bright">QLatin1Char</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">'0'</span></span><span class="bright"></span><span class="p"><span class="bright">))</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                         <span style="color: #aa2211">+</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">separator</span><span class="p">()</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">0 is enough here.</p></blockquote></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi </div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D8968" rel="noreferrer">https://phabricator.kde.org/D8968</a></div></div><br /><div><strong>To: </strong>ahartmetz, KDE PIM, dvratil<br /><strong>Cc: </strong>knauss, KDE PIM, dvasin, winterz, vkrause, mlaurent, dvratil<br /></div>