D5667: delay filtering to the point when a new item gets its remote id

[Daniel Vrátil]

dvratil added inline comments.

INLINE COMMENTS

> mkoller wrote in mailfilteragent.cpp:129
> It's your code, so I follow your rules.
> However from an OO point of view, I do not like classes which return non-const refs to members.
> That's changing things behind the back of the owner class.
> In that case the member could also just be public, which also circumvents the OO mechanism.
> 
> Please tell me if I shall do it like you proposed or if I shall commit as is.

You are right, it's not a good API design and it's very non-standard in Qt, but since we already have it, let's use it (consistency ftw).

Killing the API could be a nice junior-job (hinthint ;-))

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D5667

To: mkoller, dvratil, mlaurent
Cc: knauss, #kde_pim, dvasin, ach, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170503/b4f5b954/attachment.html>