D5667: delay filtering to the point when a new item gets its remote id

[Daniel Vrátil]

dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.


  Looks good, thanks!

INLINE COMMENTS

> mailfilteragent.cpp:129
> +    scope.setAncestorRetrieval(Akonadi::ItemFetchScope::Parent);
> +    itemMonitor->setItemFetchScope(scope);
> +    connect(itemMonitor, &Akonadi::Monitor::itemChanged, this, &MailFilterAgent::slotItemChanged);

There's also a non-const Monitor::itemFetchScope() overload that returns a non-const reference, so you can do

  itemMonitor->itemFetchScope().setFetchRemoteIdentification(true)

Not a big issue, you can fix it before committing if you want to.

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D5667

To: mkoller, dvratil, mlaurent
Cc: knauss, #kde_pim, dvasin, ach, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170503/d921b1a0/attachment.html>