D5680: remove unused (and buggy) method
Daniel Vrátil
noreply at phabricator.kde.org
Wed May 3 09:39:54 BST 2017
dvratil accepted this revision.
dvratil added a comment.
This revision is now accepted and ready to land.
Thanks, must be a forgotten leftover from early prototyping.
Fix the minors and commit.
INLINE COMMENTS
> protocol.cpp:778
> QDebug dbg(_dbg.noquote());
> - return dbg << "Item" << item.id << "(RID:" << item.remoteId
> + return dbg << "Item:" << item.id << "(RID:" << item.remoteId
> << ", RREV:" << item.remoteRevision << ", mimetype: " << item.mimeType;
You can commit this, but commit it as a separate commit, please.
> protocol_p.h:262-264
> private:
> - static CommandPtr deserializeImpl(QIODevice *device);
> template<typename T>
> friend CommandPtr deserialize(QIODevice *device);
This can go too now.
REPOSITORY
R165 Akonadi
REVISION DETAIL
https://phabricator.kde.org/D5680
To: mkoller, dvratil
Cc: #kde_pim, dvasin, ach, winterz, vkrause, mlaurent, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170503/ea4b3cda/attachment.html>
More information about the kde-pim
mailing list