<table><tr><td style="">dvratil accepted this revision.<br />dvratil added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5680" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Thanks, must be a forgotten leftover from early prototyping.</p>

<p>Fix the minors and commit.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5680#inline-23221" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">protocol.cpp:778</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QDebug</span> <span class="n">dbg</span><span class="p">(</span><span class="n">_dbg</span><span class="p">.</span><span class="n">noquote</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">return</span> <span class="n">dbg</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Item"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">id</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"(RID:"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">remoteId</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">return</span> <span class="n">dbg</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"Item<span class="bright">:</span>"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">id</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"(RID:"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">remoteId</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">               <span style="color: #aa2211"><<</span> <span style="color: #766510">", RREV:"</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">remoteRevision</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">", mimetype: "</span> <span style="color: #aa2211"><<</span> <span class="n">item</span><span class="p">.</span><span class="n">mimeType</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You can commit this, but commit it as a separate commit, please.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5680#inline-23223" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">protocol_p.h:262-264</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #a0a000">private</span><span class="p">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">static</span> <span class="n">CommandPtr</span> <span class="n">deserializeImpl</span><span class="p">(</span><span class="n">QIODevice</span> <span style="color: #aa2211">*</span><span class="n">device</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">template</span><span style="color: #aa2211"><</span><span style="color: #304a96">typename</span> <span class="n">T</span><span style="color: #aa2211">></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">friend</span> <span class="n">CommandPtr</span> <span class="n">deserialize</span><span class="p">(</span><span class="n">QIODevice</span> <span style="color: #aa2211">*</span><span class="n">device</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This can go too now.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi </div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5680" rel="noreferrer">https://phabricator.kde.org/D5680</a></div></div><br /><div><strong>To: </strong>mkoller, dvratil<br /><strong>Cc: </strong>KDE PIM, dvasin, ach, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>