[Differential] [Changed Subscribers] D4460: Port auto-encryption in KMail's composer to Trust Levels

[Sandro Knauß]

knauss added inline comments.

INLINE COMMENTS

> kmcomposerwin.cpp:3420
> +        switch (Kleo::trustLevel(userID)) {
> +        case Kleo::Level0:
> +            // no encryption on this level

Level0 is also true when the key was nevr used to write encrypted. Well normally you want to start writing encrypted if there is a key, so you also need to detect this case.

> kmcomposerwin.cpp:3425
> +            overlay = QIcon::fromTheme(QStringLiteral("emblem-information"));
> +            tooltip = i18n("The encryption key is only marginally trusted and hasn't been used enough time to guarantee it belongs to the stated person. "
>                             "Click the icon for details.");

[...] and hansn't used often enough to garantee that it belongs to the stated person.

> kmcomposerwin.cpp:3430
> +            overlay = QIcon::fromTheme(QStringLiteral("emblem-added"));
> +            tooltip = i18n("The encryption key is only marginally trusted, but has been used enough times to be very likely controlled by the stated person. "
>                             "Click the icon for details.");

[...], but the key was used several times succellfully, so it is very likely, that the key is controlled by the stated person.

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D4460

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, aheinecke, bjoernbalazs
Cc: knauss, #kde_pim_kmail, #kde_pim, dvasin, hrouis, winterz, vkrause, mlaurent, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170207/88836615/attachment.html>