[Differential] [Requested Changes To] D4443: Make libgit2 actually optional for tests

Christian Mollekopf noreply at phabricator.kde.org
Mon Feb 13 19:27:49 GMT 2017


cmollekopf requested changes to this revision.
cmollekopf added a reviewer: cmollekopf.
cmollekopf added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:38
>  qt5_use_modules(${PROJECT_NAME} Core)
> -target_link_libraries(${PROJECT_NAME} lib${PROJECT_NAME} ${LIBGIT2_LIBRARIES})
>  if (LIBGIT2_FOUND)

This looks like it no longer links against libgit in any case?

REPOSITORY
  R9 Sink

REVISION DETAIL
  https://phabricator.kde.org/D4443

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: heikobecker, #kde_pim, cmollekopf
Cc: cmollekopf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170213/83e02e43/attachment.html>


More information about the kde-pim mailing list