<table><tr><td style="">cmollekopf requested changes to this revision.<br />cmollekopf added a reviewer: cmollekopf.<br />cmollekopf added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4443" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4443#inline-18333" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:38</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">qt5_use_modules(${PROJECT_NAME} Core)
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">target_link_libraries(${PROJECT_NAME} lib${PROJECT_NAME}<span class="bright"> ${LIBGIT2_LIBRARIES}</span>)
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">target_link_libraries(${PROJECT_NAME} lib${PROJECT_NAME})
</div><div style="padding: 0 8px; margin: 0 4px; ">if (LIBGIT2_FOUND)
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This looks like it no longer links against libgit in any case?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R9 Sink</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4443" rel="noreferrer">https://phabricator.kde.org/D4443</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>heikobecker, KDE PIM, cmollekopf<br /><strong>Cc: </strong>cmollekopf<br /></div>