D7107: Move QMenu allocation from heap to stack

Sergio Martins noreply at phabricator.kde.org
Sat Aug 12 20:22:22 BST 2017


smartins added a comment.


  stack is always a good default
  
  Note however that the performance claims don't apply here because menu.exec() is a "time bottleneck", if you call this function 100000 times you can't say it ran noticeably faster, since all the time was spent in exec().
  
  anyway, +1, it's good to have code without new and delete

REPOSITORY
  R206 KMail

REVISION DETAIL
  https://phabricator.kde.org/D7107

To: dkurz, #kde_pim_kmail
Cc: smartins, dvratil, mlaurent, #kde_pim, dvasin, winterz, vkrause, knauss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20170812/8ed32615/attachment.html>


More information about the kde-pim mailing list