<table><tr><td style="">smartins added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7107" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>stack is always a good default</p>
<p>Note however that the performance claims don't apply here because menu.exec() is a "time bottleneck", if you call this function 100000 times you can't say it ran noticeably faster, since all the time was spent in exec().</p>
<p>anyway, +1, it's good to have code without new and delete</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R206 KMail</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7107" rel="noreferrer">https://phabricator.kde.org/D7107</a></div></div><br /><div><strong>To: </strong>dkurz, KDE PIM: KMail<br /><strong>Cc: </strong>smartins, dvratil, mlaurent, KDE PIM, dvasin, winterz, vkrause, knauss<br /></div>