[Differential] [Requested Changes To] D3140: Add formatters for application/pgp-keys and application/vnd.gnupg.wks body parts

[mlaurent (Laurent Montel)]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> gnupgwksmemento.cpp:180
> +        // Send the message
> +        auto smtp = new MailTransport::SmtpJob(transport);
> +        smtp->setSender(mAddress);

We need to depend against new kmailtransport (install smtpjob.h)
Did you update kmailtransport version in CMakeLists.txt kdepim-addons toplevel ?

> gnupgwksmemento.h:43
> +
> +    explicit GnuPGWKSMemento();
> +    ~GnuPGWKSMemento();

explicit without argument ?
I think that you can remove explicit here

> gnupgwksmemento.h:71
> +    {
> +        Q_EMIT update(MimeTreeParser::Force);
> +    }

could you move it in cpp file ? thanks

> pgpkeymemento.h:38
> +public:
> +    explicit PgpKeyMemento();
> +    ~PgpKeyMemento();

not necessary to add explicit here too

> pgpkeymessagepart.cpp:101
> +        if (cols[0] == "pub" && mKeyID.isEmpty()) {
> +            if (cols.size() > 4) {
> +                mKeyID = QString::fromUtf8(cols[4]);

Perhaps we can cache "cols.size()" to avoid to recall this method no ?

REPOSITORY
  rKDEPIMADDONS KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D3140

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, bjoernbalazs, aheinecke, mlaurent
Cc: emanuel, mlaurent, kde-pim, #kde_pim, spencerb, dvasin, winterz, vkrause, knauss, dvratil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161024/75803095/attachment.html>