Review Request 128605: [kmail] Fix jump lists by renaming org.kde.{kmail => kmail2}.desktop

[Laurent Montel]

> On Aug. 5, 2016, 5:02 a.m., Laurent Montel wrote:
> > For sure it will not commit in 16.08 it's too late.
> > We use some code which requires org.kde.kmail so it will break it.
> > So it will evaluate for 16.12 not 16.08.
> > 
> > Regards
> 
> Daniel Vrátil wrote:
>     Since the code that uses org.kde.kmail.desktop is all internal, it should be easy to just adjust it everywhere as needed? I found in total only 5 occurrences where this needs changing:
>     
>         ./pim/kdepim-apps-libs/libkdepimdbusinterfaces/src/urihandler.cpp:45:        const QString desktopFile = QStandardPaths::locate(QStandardPaths::ApplicationsLocation, QStringLiteral("org.kde.kmail.desktop"))
>         ./pim/kdepim-apps-libs/libkdepimdbusinterfaces/src/urihandler.cpp:95:            const QString desktopFile = QStandardPaths::locate(QStandardPaths::ApplicationsLocation, QStringLiteral("org.kde.kmail.desktop"));
>         ./kmail/agents/followupreminderagent/jobs/followupremindershowmessagejob.cpp:49:        if (KToolInvocation::startServiceByDesktopName(QStringLiteral("org.kde.kmail"), QString(), &errmsg)) {
>         ./kmail/src/tests/ktoolinvocationtest.cpp:46:    if (KToolInvocation::startServiceByDesktopName(QStringLiteral("org.kde.kmail"), QString(), &errmsg)) {
>         ./kalarm/src/functions.cpp:1398:        if (KToolInvocation::startServiceByDesktopName(QStringLiteral("org.kde.kmail"), QString(), &errmsg))
> 
> Andreas Sturmlechner wrote:
>     Hm, also in ./kmail/agents/followupreminderagent/jobs/followupremindershowmessagejob.cpp there are:
>     
>     const QString kmailInterface = QStringLiteral("org.kde.kmail");
>     [...]
>     QDBusInterface kmail(kmailInterface, QStringLiteral("/KMail"), QStringLiteral("org.kde.kmail.kmail"));
>     
>     How do those relate and does that mean this change generally needs a closer look?
> 
> Laurent Montel wrote:
>     nope interface must not be change.
>     
>     @daniel I know as I fixed it last week for kdepim
>     
>     but it doesn't change problem as it will not put in 16.08.
>     And we perhaps need to adapt plasma support which has desktop file named kmail.desktop or others. We don't know all problem that we will see with this rename.
>     So it's not just an easy rename so it's the reason that it will evaluate for 16.12.
> 
> Daniel Vrátil wrote:
>     Laurent, is it too late to re-evaluate this for 16.12, or can we still squeeze it in?

Beta1 => too late for sure.
Next try for 17.04


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128605/#review98125
-----------------------------------------------------------


On Aug. 4, 2016, 9:29 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128605/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 9:29 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Currently broken because WM_CLASS is set to 'kmail2' which does not correspond with desktop file.
> 
> some IRC log:
> 
> Sho_: let me give you some context
> Sho_: Plasma's Task Manager contains a complicated heuristic that tries to find out what app a window belongs to, working off of window and process metadata
> Sho_: it's necessary to e.g. pin an app as a launcher based on a window, or to group windows belonging to the same app, or fetch jump list actions from the .desktop file
> Sho_: because kmail sets bad metadata, the heuristic works only as far as being able to find the executable - that's enough to store a launcher, which then points at the executable and uses a base64 serialization of the window icon as icon for it
> Sho_: but since it can't find the .desktop file, it can't e.g. show jump lists (or grab the right icon from the icon theme based on icon name)
> 
> 
> Diffs
> -----
> 
>   kmail/src/CMakeLists.txt 3df422d731393263f00ff26c35e62e47ec851d6f 
>   kmail/src/data/org.kde.kmail.appdata.xml  
>   kmail/src/data/org.kde.kmail.desktop  
> 
> Diff: https://git.reviewboard.kde.org/r/128605/diff/
> 
> 
> Testing
> -------
> 
> builds and runs, now also has jump lists (if kmail is started standalone)
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20161111/e2027690/attachment.html>