<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128605/">https://git.reviewboard.kde.org/r/128605/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 5th, 2016, 5:02 a.m. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For sure it will not commit in 16.08 it's too late.
We use some code which requires org.kde.kmail so it will break it.
So it will evaluate for 16.12 not 16.08.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regards</p></pre>
</blockquote>
<p>On August 5th, 2016, 12:46 p.m. UTC, <b>Daniel Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since the code that uses org.kde.kmail.desktop is all internal, it should be easy to just adjust it everywhere as needed? I found in total only 5 occurrences where this needs changing:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span><span style="color: #666666">./</span><span style="color: #008000; font-weight: bold">pim</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">kdepim-apps-libs</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">libkdepimdbusinterfaces</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">src</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">urihandler</span><span style="color: #0000FF; font-weight: bold">.cpp</span><span style="color: #AA22FF">:45</span><span style="color: #666666">:</span> <span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">QString</span> <span style="color:
#008000; font-weight: bold">desktopFile</span> <span style="color: #666666">=</span> <span style="color: #008000; font-weight: bold">QStandardPaths</span><span style="color: #666666">:</span><span style="color: #AA22FF">:locate</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">QStandardPaths</span><span style="color: #666666">:</span><span style="color: #AA22FF">:ApplicationsLocation</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">QStringLiteral</span><span style="color: #666666">(</span><span style="color: #BA2121">"org.kde.kmail.desktop"</span><span style="color: #666666">))</span>
<span style="color: #666666">./</span><span style="color: #008000; font-weight: bold">pim</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">kdepim-apps-libs</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">libkdepimdbusinterfaces</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">src</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">urihandler</span><span style="color: #0000FF; font-weight: bold">.cpp</span><span style="color: #AA22FF">:95</span><span style="color: #666666">:</span> <span style="color: #008000; font-weight: bold">const</span> <span style="color: #008000; font-weight: bold">QString</span> <span style="color: #008000; font-weight: bold">desktopFile</span> <span style="color: #666666">=</span> <span style="color: #008000; font-weight: bold">QStandardPaths</span><span style="color: #666666">:</span>
<span style="color: #AA22FF">:locate</span><span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">QStandardPaths</span><span style="color: #666666">:</span><span style="color: #AA22FF">:ApplicationsLocation</span><span style="color: #666666">,</span> <span style="color: #008000; font-weight: bold">QStringLiteral</span><span style="color: #666666">(</span><span style="color: #BA2121">"org.kde.kmail.desktop"</span><span style="color: #666666">));</span>
<span style="color: #666666">./</span><span style="color: #008000; font-weight: bold">kmail</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">agents</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">followupreminderagent</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">jobs</span><span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">followupremindershowmessagejob</span><span style="color: #0000FF; font-weight: bold">.cpp</span><span style="color: #AA22FF">:49</span><span style="color: #666666">:</span> <span style="color: #008000; font-weight: bold">if</span> <span style="color: #666666">(</span><span style="color: #008000; font-weight: bold">KToolInvocation</span><span style="color: #666666">:</span><span style="color: #AA22FF">:startServiceByDesktopName</span><span style="color: #666666">(</span><span style="color: #008000
; font-weight: bold">QStringLiteral</span><span style="color: #666666">(</span><span style="color: #BA2121">"org.kde.kmail"</span><span style="color: #666666">),</span> <span style="color: #008000; font-weight: bold">QString</span><span style="color: #666666">(),</span> <span style="color: #666666">&</span><span style="color: #008000; font-weight: bold">errmsg</span><span style="color: #666666">))</span> {
<span style="color: #666666">./</span>kmail<span style="color: #666666">/</span>src<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>ktoolinvocationtest<span style="color: #666666">.</span>cpp<span style="color: #666666">:46:</span> if (KToolInvocation<span style="color: #666666">::</span>startServiceByDesktopName(QStringLiteral(<span style="color: #BA2121">"org.kde.kmail"</span>)<span style="color: #666666">,</span> QString()<span style="color: #666666">,</span> <span style="color: #666666">&</span>errmsg)) <span style="border: 1px solid #FF0000">{</span>
<span style="color: #666666">./</span>kalarm<span style="color: #666666">/</span>src<span style="color: #666666">/</span>functions<span style="color: #666666">.</span>cpp<span style="color: #666666">:1398:</span> if (KToolInvocation<span style="color: #666666">::</span>startServiceByDesktopName(QStringLiteral(<span style="color: #BA2121">"org.kde.kmail"</span>)<span style="color: #666666">,</span> QString()<span style="color: #666666">,</span> <span style="color: #666666">&</span>errmsg))
</pre></div>
</p></pre>
</blockquote>
<p>On August 7th, 2016, 12:33 p.m. UTC, <b>Andreas Sturmlechner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hm, also in ./kmail/agents/followupreminderagent/jobs/followupremindershowmessagejob.cpp there are:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">const QString kmailInterface = QStringLiteral("org.kde.kmail");
[...]
QDBusInterface kmail(kmailInterface, QStringLiteral("/KMail"), QStringLiteral("org.kde.kmail.kmail"));</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How do those relate and does that mean this change generally needs a closer look?</p></pre>
</blockquote>
<p>On August 7th, 2016, 4 p.m. UTC, <b>Laurent Montel</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">nope interface must not be change.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@daniel I know as I fixed it last week for kdepim</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but it doesn't change problem as it will not put in 16.08.
And we perhaps need to adapt plasma support which has desktop file named kmail.desktop or others. We don't know all problem that we will see with this rename.
So it's not just an easy rename so it's the reason that it will evaluate for 16.12.</p></pre>
</blockquote>
<p>On November 11th, 2016, 1:32 p.m. UTC, <b>Daniel Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Laurent, is it too late to re-evaluate this for 16.12, or can we still squeeze it in?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Beta1 => too late for sure.
Next try for 17.04</p></pre>
<br />
<p>- Laurent</p>
<br />
<p>On August 4th, 2016, 9:29 p.m. UTC, Andreas Sturmlechner wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDEPIM and Laurent Montel.</div>
<div>By Andreas Sturmlechner.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2016, 9:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepim
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently broken because WM_CLASS is set to 'kmail2' which does not correspond with desktop file.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">some IRC log:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sho_: let me give you some context
Sho_: Plasma's Task Manager contains a complicated heuristic that tries to find out what app a window belongs to, working off of window and process metadata
Sho_: it's necessary to e.g. pin an app as a launcher based on a window, or to group windows belonging to the same app, or fetch jump list actions from the .desktop file
Sho_: because kmail sets bad metadata, the heuristic works only as far as being able to find the executable - that's enough to store a launcher, which then points at the executable and uses a base64 serialization of the window icon as icon for it
Sho_: but since it can't find the .desktop file, it can't e.g. show jump lists (or grab the right icon from the icon theme based on icon name)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds and runs, now also has jump lists (if kmail is started standalone)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmail/src/CMakeLists.txt <span style="color: grey">(3df422d731393263f00ff26c35e62e47ec851d6f)</span></li>
<li>kmail/src/data/org.kde.kmail.appdata.xml <span style="color: grey">()</span></li>
<li>kmail/src/data/org.kde.kmail.desktop <span style="color: grey">()</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128605/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>