[Kde-pim] Review Request 127966: Port all instances of Kauthorized action/shell_command to shell_command

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127966/#review95625
-----------------------------------------------------------


Ship it!




Seems good.
Ship it.
Thanks

- Laurent Montel


On May 19, 2016, 2:49 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127966/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 2:49 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The KAuthorized key to prevent shell access according the documentation
> is simply "shell_action" not "action/shellAction" so should use
> authorize not authorizeKAction
> 
> This appears to have come about as part of a porting bug when going from
> KApplication::authorize to KAuthorized in kdelibs3 to kdelibs4.
> 
> To currently block shell access a sysadmin currently needs to
> have both keys set already, so we can be confident it won't have any
> actual compatibility problems.
> 
> 
> Diffs
> -----
> 
>   kalarm/src/lib/shellprocess.cpp c3f90acc19233319944fc7aeaecf69b35c9aef9b 
> 
> Diff: https://git.reviewboard.kde.org/r/127966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/