[Kde-pim] [Differential] [Commented On] D1636: Implement client-side threading cache

dvratil (Daniel Vrátil) noreply at phabricator.kde.org
Sat May 21 14:16:33 BST 2016


dvratil added inline comments.

INLINE COMMENTS

> dfaure wrote in model.cpp:762
> This reads strange... What is the purpose of save() followed by load()? It sounds like reloading what we just saved, i.e. the load being a no-op. I'm guessing this isn't the case, but then it's worth a comment or renaming....

The in-memory cache gets dynamically updated when new emails arrive and are threaded by the model (or simply when you open a folder there's no cache for yet). When new folder is opened, Model::setStorageModel() is called and that's when we save() the in-memory cache of the old folder threading into a file, and then load() threading cache of the newly-selected folder.

REPOSITORY
  rMESSAGELIB PIM: Message Library

REVISION DETAIL
  https://phabricator.kde.org/D1636

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dvratil, mlaurent, vkrause, dfaure
Cc: kde-pim, dvasin, winterz, smartins, vkrause, mlaurent, knauss, dvratil
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list