[Kde-pim] Review Request 127228: [kleopatra] Drop duplicate check from root and make it optional

[Andre Heinecke]

> On March 1, 2016, 6:22 a.m., Laurent Montel wrote:
> > CMakeLists.txt, line 224
> > <https://git.reviewboard.kde.org/r/127228/diff/1/?file=446050#file446050line224>
> >
> >     check is still necessary.
> 
> Andreas Sturmlechner wrote:
>     The exact same check is done in kleopatra/CMakeLists.txt (of course there it is fatal), so it's an opportunity for a small cleanup

After the discussion we had yesterday in IRC I've had a look at this. I think Boost graph should be removed as dependency for Kleopatra. I want to do some more testing before I put it up for review but I think https://paste.kde.org/pzmwhrazx should do the trick.


> On March 1, 2016, 6:22 a.m., Laurent Montel wrote:
> > CMakeLists.txt, line 236
> > <https://git.reviewboard.kde.org/r/127228/diff/1/?file=446050#file446050line236>
> >
> >     kleopatra is necessary for kmail too why you want to disable build ?
> 
> Andreas Sturmlechner wrote:
>     Even the existing logic makes kleopatra conditional to Boost_TOPOLOGICAL_SORT_DIR and Gpemepp, so that's not the impression I got? But this is not about simply disabling kleopatra anyway - it can be built completely separate within its own directory, and if you do that, you want to be able to disable it for the rest of kdepim.

I think the real solution for your Problem (Packaging Kleo standalone and then Packaging Kdepim without Kleo) is to put Kleopatra into a different repo / release tarball. Kleopatra should be a runtime dependency of KMail (For Crypto configuration and certificate details / management). But Kleopatra can be build / installed standalone. I'll write to the Mailing list asking how we should move foward with this.


- Andre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127228/#review92962
-----------------------------------------------------------


On Feb. 29, 2016, 10:03 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127228/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 10:03 p.m.)
> 
> 
> Review request for KDEPIM, Andre Heinecke and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Same check exists in kleopatra/CMakeLists.txt already.
> 
> Going forward, ecm_optional_add_subdirectory provides a convenient handle to switch kleopatra on or off.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 63384efb9c495bd3f9f2b507ef747cac7844deaa 
> 
> Diff: https://git.reviewboard.kde.org/r/127228/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/