[Kde-pim] Review Request 127228: [kleopatra] Drop duplicate check from root and make it optional

Laurent Montel montel at kde.org
Tue Mar 1 06:21:59 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127228/#review92962
-----------------------------------------------------------




CMakeLists.txt 
<https://git.reviewboard.kde.org/r/127228/#comment63396>

    check is still necessary.



CMakeLists.txt (line 227)
<https://git.reviewboard.kde.org/r/127228/#comment63397>

    kleopatra is necessary for kmail too why you want to disable build ?


- Laurent Montel


On fév. 29, 2016, 10:03 après-midi, Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127228/
> -----------------------------------------------------------
> 
> (Updated fév. 29, 2016, 10:03 après-midi)
> 
> 
> Review request for KDEPIM, Andre Heinecke and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Same check exists in kleopatra/CMakeLists.txt already.
> 
> Going forward, ecm_optional_add_subdirectory provides a convenient handle to switch kleopatra on or off.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 63384efb9c495bd3f9f2b507ef747cac7844deaa 
> 
> Diff: https://git.reviewboard.kde.org/r/127228/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list