[Kde-pim] Review Request 127518: pop3: Delete emails as we know we have saved them correctly instead of waiting to save them all

[Daniel Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127518/#review94115
-----------------------------------------------------------


Ship it!




Haven't tested, but looks good to me.

- Daniel Vrátil


On March 29, 2016, 1:36 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127518/
> -----------------------------------------------------------
> 
> (Updated March 29, 2016, 1:36 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> This patch removes the "Delete" state. This means that instead of:
>  * Save all messages
>  * Delete messages that need deletion
> 
> What we do is
>  * Save one message
>  * If that message needs deletion and there's no deletion job in process delete it, otherwise note it down for deletion later
> 
> This has two effects:
>  * The whole process is faster since we can start deleting emails as we know we have saved it correctly instead of having to wait to save them all
>  * The communication with the server is more continuous and that makes the yahoo server don't close the connection on me (before the "save all messages" state when downloading 200 emails sometimes takes more than 30 seconds and the yahoo server decides that if there has been no communication for more than 30 seconds it will close down the connection, and then very bad things happen since we try to delete the messages and the connection is gone, basically ending up in an infite loop of download 200 emails, saving takes more than 30 seconds, server closes connection, can't delete, download 200 emails, saving takes more than 30 seconds, server closes connection, etc.)
> 
> 
> Diffs
> -----
> 
>   resources/pop3/pop3resource.h ab12c61 
>   resources/pop3/pop3resource.cpp daac445 
> 
> Diff: https://git.reviewboard.kde.org/r/127518/diff/
> 
> 
> Testing
> -------
> 
> Been using it for a few days, all seems good.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/